Using list of characters instead of a string for Problem 24.8 #151 #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tsunghsienlee, @adnanaziz, @metopa I have submitted a PR to outline my fix for issue #151. Please review the same at your convenience and I will address any concerns with the same in the PR |
|
Generally it looks good to me, and I probably will omit |
tsunghsienlee
approved these changes
Jan 27, 2020
|
Hope you are doing well. I just saw that this PR has been sitting in an open state since a few months now. May I know when do you plan to merge this PR to master? |
|
@deveshks Hi there, sorry for the long wait. I'll check this out right after I do my state exams at the end of June. I'll keep you updated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to use a list of characters instead of a string to represent an added word for Problem 24.8 in order to avoid the extra time complexity associated with string concatentations